Replace calls to performance API with LAMP data (Version 4.1) #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinmatte
changed the title
github-actions
bot
added
ci/cd
devinmatte
requested review from
mathcolo,
nathan-weinberg,
austinjpaul,
idreyn,
skaplan-dev and
PatrickCleary
as code owners
salil-khanna
reviewed
May 6, 2024
| "S3 Headway Fetching": ( | ||
| lambda: "2020-11-07T10:33:40" | ||
| in json.dumps(data_funcs.headways(date(year=2020, month=11, day=7), ["70061"])) | ||
| ), | ||
| "Performance API Check": ( |
There was a problem hiding this comment.
Briefly read architecture docs, but based on this PR, I'm assuming that LAMP data is held in a separate repo through an s3 bucket? So the S3 Headway Fetching thats done above covers the check for LAMP as well?
Also why did the MbtaPerformanceAPI need a check but not MbtaAPIV3/V2?
There was a problem hiding this comment.
LAMP data is processed through mbta-performance and stored in s3. We read from s3 here, so yes. That check is sufficient for both
We don't have any checks for the v3 api mostly because we haven't relied on the v3 api for much in the app. Now we only use it to show current accessibility alerts, so we could add a check here, just haven't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Replace all calls to the performance API with LAMP data, and gobble as fallback
Changes
npm updateto do some package cleanup and updatingDepends on
Do not consider merging until we've finished these issues
Testing Instructions
Go to beta, compare results to prod